This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Fix GH-103: Create SWF regardless of platform #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port LLK/scratchr2#4168 for ScratchX. Original description from that change: > This fixes #4112 by creating the swf regardless of OS and browser. > Calling `embedSWF` would first check for the existence of the plugin > before creating, causing browsers that don’t allow the flash plugin by > default to not be able to show their “allow” message. This tries to > create the swf no matter what, allowing browsers to detect flash > themselves. > > Logic is as follows: > 1. check if `userAgent` returns a mobile/tablet OS. Display error > message if so > 2. check if on windows and using ie – check for an express install if > so (like in `embedSWF`) > 3. load the swf in all other cases, let browsers handle it. > > Test Cases: > - Test how project pages load in Android and iOS devices, on tablets > and on phones, and on multiple desktop OS's for correct loading > behavior. This resolves scratchfoundation#103
mewtaylor
approved these changes
Jan 4, 2017
rschamp
approved these changes
Jan 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port LLK/scratchr2#4168 for ScratchX.
Note that this change adds Bowser as a ScratchX dependency. For consistency, I used the same version that we currently use in scratchr2.
Original description from LLK/scratchr2#4168:
This resolves #103